Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize glob #71

Merged
merged 2 commits into from
Nov 29, 2022
Merged

Optimize glob #71

merged 2 commits into from
Nov 29, 2022

Conversation

Katsute
Copy link
Member

@Katsute Katsute commented Nov 29, 2022

Prerequisites

Issues must meet the following criteria:

  • No similar pull request exists.
  • Code follows the general code style of this project.
  • No sensitive information is exposed.
  • Relevant comments have been added.

GitHub Copilot Disclaimer

The use of GitHub Copilot is strictly prohibited on this repository.

  • This pull does not use GitHub Copilot.

Changes Made

List any changes made and/or other relevant issues.

  • Move glob to dedicated lib
  • Skip dir, sort on glob
  • Optimize array parameters
  • Make image rendering pixelated

@Katsute Katsute self-assigned this Nov 29, 2022
@Katsute

This comment has been minimized.

Sign in to view
ghost
ghost approved these changes Nov 29, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Katsute I have approved this pull request

@Katsute Katsute merged commit c09661c into main Nov 29, 2022
@Katsute Katsute deleted the optimize-glob@89ff275 branch November 29, 2022 22:14
@ghost ghost locked and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
Assignees

@Katsute Katsute

Labels
optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Katsute